👔 Changed to transactions #297

src/helpers/saveUser/index.ts

@@ -1,43 +0,0 @@
-import sleep from "../../helpers/sleep";
-import logger from "../../logger";
-import Chance from "chance";
-
-export default async function saveUser(data: any, data2: any) {
-  process.nextTick(
-    async () => {
-      // Chance module
-      const chance = new Chance();
-
-      await sleep(
-        chance.integer({
-          min: 0,
-          max: 1,
-        }) *
-          10 +
-          1 * 100
-      ); // 100 - 1000 random  Number generator
-      data.save((_: any) =>
-        _
-          ? logger?.error(
-              `ERROR Occurred while saving data (saveUser) \n${"=".repeat(
-                50
-              )}\n${`${_}\n${"=".repeat(50)}`}`
-            )
-          : logger?.silly(`Saved user: ${data.id} (saveUser)`)
-      );
-      if (data2) {
-        data2.save((_: any) =>
-          _
-            ? logger?.error(
-                `ERROR Occurred while saving data (saveUser) \n${"=".repeat(
-                  50
-                )}\n${`${_}\n${"=".repeat(50)}`}`
-              )
-            : logger?.silly(`Saved user: ${data2.id} (saveUser)`)
-        );
-      }
-    },
-    data,
-    data2
-  );
-}

src/helpers/sleep/index.ts

@@ -1,8 +0,0 @@
-import logger from "../../logger";
-
-export default function sleep(milliseconds: number) {
-  return new Promise((resolve) => {
-    setTimeout(resolve, milliseconds);
-    logger?.silly(`Sleeping for ${milliseconds} milliseconds`);
-  });
-}

src/plugins/credits/modules/gift/index.ts

@@ -7,8 +7,7 @@ import getEmbedConfig from "../../../../helpers/getEmbedConfig";
 // Handlers
 import logger from "../../../../logger";
 
-// Helpers
+import mongoose from "mongoose";
-import saveUser from "../../../../helpers/saveUser";
 
 // Models
 import fetchUser from "../../../../helpers/fetchUser";
@@ -184,41 +183,58 @@ export default {
       });
     }
 
+    const session = await mongoose.startSession();
+
+    session.startTransaction();
+
+    try {
       // Withdraw amount from fromUserDB
       fromUserDB.credits -= optionAmount;
 
       // Deposit amount to toUserDB
       toUserDB.credits += optionAmount;
 
-    // Save users
+      await fromUserDB.save();
-    await saveUser(fromUserDB, toUserDB).then(async () => {
-      // Get DM user object
-      const dmUser = client.users.cache.get(optionUser.id);
 
-      if (dmUser == null) return;
+      await toUserDB.save();
 
-      // Send DM to user
+      await session.commitTransaction();
-      await dmUser
+    } catch (error) {
-        .send({
+      await session.abortTransaction();
+      session.endSession();
+      logger.error(`${error}`);
+
+      return interaction.editReply({
         embeds: [
           embed
             .setDescription(
-                `${
+              "An error occurred while trying to gift credits. Please try again."
-                  user.tag
+            )
-                } has gifted you ${optionAmount} credits with reason: ${
+            .setColor(errorColor),
+        ],
+      });
+    } finally {
+      // ending the session
+      session.endSession();
+    }
+
+    // Get DM user object
+    const dmUser = client.users.cache.get(optionUser.id);
+
+    if (!dmUser) throw new Error("User not found");
+
+    // Send DM to user
+    await dmUser.send({
+      embeds: [
+        embed
+          .setDescription(
+            `${user.tag} has gifted you ${optionAmount} credits with reason: ${
               optionReason || "unspecified"
             }`
           )
           .setColor(successColor),
       ],
-        })
+    });
-        .catch(async (error) =>
-          logger.error(`[Gift] Error sending DM to user: ${error}`)
-        );
-
-      logger.silly(
-        `[Gift] Successfully gifted ${optionAmount} credits to ${optionUser.tag}`
-      );
 
     return interaction.editReply({
       embeds: [
@@ -231,6 +247,5 @@ export default {
           .setColor(successColor),
       ],
     });
-    });
   },
 };

src/plugins/manage/modules/credits/modules/transfer/index.ts

@@ -1,15 +1,14 @@
 // Dependencies
 import { CommandInteraction, MessageEmbed, Permissions } from "discord.js";
 
+import mongoose from "mongoose";
+
 // Configurations
 import getEmbedConfig from "../../../../../../helpers/getEmbedConfig";
 
 // Handlers
 import logger from "../../../../../../logger";
 
-// Helpers
-import saveUser from "../../../../../../helpers/saveUser";
-
 // Models
 import fetchUser from "../../../../../../helpers/fetchUser";
 import { SlashCommandSubcommandBuilder } from "@discordjs/builders";
@@ -193,15 +192,44 @@ export default {
       });
     }
 
-    // Withdraw amount from fromUser
+    const session = await mongoose.startSession();
+
+    session.startTransaction();
+
+    try {
+      // Withdraw amount from fromUserDB
       fromUser.credits -= optionAmount;
 
-    // Deposit amount to toUser
+      // Deposit amount to toUserDB
       toUser.credits += optionAmount;
 
-    // Save users
+      await fromUser.save();
-    await saveUser(fromUser, toUser)?.then(async () => {
+
-      logger?.silly(`Saved users`);
+      await toUser.save();
+
+      await session.commitTransaction();
+    } catch (error) {
+      await session.abortTransaction();
+      session.endSession();
+      logger.error(`${error}`);
+
+      return interaction.editReply({
+        embeds: [
+          new MessageEmbed()
+            .setTitle("[:toolbox:] Manage - Credits (Transfer)")
+            .setDescription(
+              "An error occurred while trying to gift credits. Please try again."
+            )
+            .setColor(errorColor)
+            .setTimestamp(new Date())
+            .setColor(successColor)
+            .setFooter({ text: footerText, iconURL: footerIcon }),
+        ],
+      });
+    } finally {
+      // ending the session
+      session.endSession();
+    }
 
     return interaction?.editReply({
       embeds: [
@@ -225,6 +253,5 @@ export default {
           .setFooter({ text: footerText, iconURL: footerIcon }),
       ],
     });
-    });
   },
 };