From 555b97d2c546257fef1fcc49d47064c6c63d6100 Mon Sep 17 00:00:00 2001
From: Vermium Sifell <vermium@zyner.org>
Date: Tue, 13 Dec 2022 14:51:16 +0100
Subject: [PATCH] refactor: :recycle: Fix more code smells

I have fixed some more code smells
---
 src/commands/config/modules/welcome/index.ts       | 1 +
 src/commands/shop/modules/cpgg/index.ts            | 1 +
 src/events/messageCreate/modules/counters/index.ts | 3 +--
 src/events/messageUpdate/index.ts                  | 1 -
 src/events/messageUpdate/modules/counter.ts        | 1 -
 src/handlers/command/index.ts                      | 1 +
 src/handlers/event/index.ts                        | 1 +
 src/handlers/schedule/index.ts                     | 1 +
 8 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/commands/config/modules/welcome/index.ts b/src/commands/config/modules/welcome/index.ts
index 40ad6fa..e59fff6 100644
--- a/src/commands/config/modules/welcome/index.ts
+++ b/src/commands/config/modules/welcome/index.ts
@@ -142,5 +142,6 @@ export default {
     await interaction?.editReply({
       embeds: [interactionEmbed],
     });
+    return;
   },
 };
diff --git a/src/commands/shop/modules/cpgg/index.ts b/src/commands/shop/modules/cpgg/index.ts
index c87c580..c7034fb 100644
--- a/src/commands/shop/modules/cpgg/index.ts
+++ b/src/commands/shop/modules/cpgg/index.ts
@@ -190,5 +190,6 @@ export default {
             });
           });
       });
+    return;
   },
 };
diff --git a/src/events/messageCreate/modules/counters/index.ts b/src/events/messageCreate/modules/counters/index.ts
index c06562a..2cc20a1 100644
--- a/src/events/messageCreate/modules/counters/index.ts
+++ b/src/events/messageCreate/modules/counters/index.ts
@@ -23,8 +23,7 @@ export default {
     });
 
     if (!channelCounter) {
-      logger.debug("No counters found in channel.");
-      return false;
+      return logger.debug("No counters found in channel.");
     }
 
     if (
diff --git a/src/events/messageUpdate/index.ts b/src/events/messageUpdate/index.ts
index 77f434c..80d3c06 100644
--- a/src/events/messageUpdate/index.ts
+++ b/src/events/messageUpdate/index.ts
@@ -25,5 +25,4 @@ export const execute = async (oldMessage: Message, newMessage: Message) => {
   if (author?.bot) return logger?.silly(`Message update event fired by bot`);
 
   await counter(newMessage);
-  return;
 };
diff --git a/src/events/messageUpdate/modules/counter.ts b/src/events/messageUpdate/modules/counter.ts
index 9f3f1f5..be33a02 100644
--- a/src/events/messageUpdate/modules/counter.ts
+++ b/src/events/messageUpdate/modules/counter.ts
@@ -38,5 +38,4 @@ export default async (message: Message) => {
     .catch((error) => {
       logger.error(error);
     });
-  return;
 };
diff --git a/src/handlers/command/index.ts b/src/handlers/command/index.ts
index a9500a1..f0b8b3b 100644
--- a/src/handlers/command/index.ts
+++ b/src/handlers/command/index.ts
@@ -33,4 +33,5 @@ export const register = async (client: Client) => {
       logger.info("🔧 All commands loaded");
     }
   }
+  return;
 };
diff --git a/src/handlers/event/index.ts b/src/handlers/event/index.ts
index e2a27b3..393c20c 100644
--- a/src/handlers/event/index.ts
+++ b/src/handlers/event/index.ts
@@ -49,4 +49,5 @@ export const register = async (client: Client) => {
       logger.info("📡 All events loaded");
     }
   }
+  return;
 };
diff --git a/src/handlers/schedule/index.ts b/src/handlers/schedule/index.ts
index 6fcbaf3..33757aa 100644
--- a/src/handlers/schedule/index.ts
+++ b/src/handlers/schedule/index.ts
@@ -21,4 +21,5 @@ export const start = async (client: Client) => {
       });
     })
   );
+  return;
 };