From 49091cb2504996744fe646e024baabaf40d0dd71 Mon Sep 17 00:00:00 2001 From: Vermium Sifell Date: Sun, 16 Oct 2022 14:57:55 +0200 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=A7=91=E2=80=8D=F0=9F=92=BB=20Fixed?= =?UTF-8?q?=20more=20code=20smells?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/plugins/events/interactionCreate/audits.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/plugins/events/interactionCreate/audits.ts b/src/plugins/events/interactionCreate/audits.ts index e4ebd19..62ca398 100644 --- a/src/plugins/events/interactionCreate/audits.ts +++ b/src/plugins/events/interactionCreate/audits.ts @@ -1,4 +1,4 @@ -import { BaseInteraction, EmbedBuilder, TextChannel } from "discord.js"; +import { BaseInteraction, ChannelType, EmbedBuilder } from "discord.js"; import getEmbedConfig from "../../../helpers/getEmbedData"; import logger from "../../../middlewares/logger"; import guildSchema from "../../../models/guild"; @@ -26,9 +26,10 @@ export default { const channel = client.channels.cache.get(`${guildData.audits.channelId}`); - if (channel === null) return; + if (!channel) return; + if (channel.type !== ChannelType.GuildText) return; - (channel as TextChannel) + channel .send({ embeds: [ new EmbedBuilder() @@ -49,15 +50,13 @@ export default { }), ], }) - .then(async () => { + .then(() => { logger.debug( `Audit log sent for event interactionCreate in guild ${interaction?.guild?.name} (${interaction?.guild?.id})` ); }) - .catch(async () => { - logger.error( - `Audit log failed to send for event interactionCreate in guild ${interaction?.guild?.name} (${interaction?.guild?.id})` - ); + .catch(() => { + logger.silly("Failed to send audit log for event interactionCreate"); }); }, }; From 05030fd1b898aa82ddd054fae8cbb92e0b477ef2 Mon Sep 17 00:00:00 2001 From: Vermium Sifell Date: Sun, 16 Oct 2022 14:59:38 +0200 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=A7=91=E2=80=8D=F0=9F=92=BB=20Fixed?= =?UTF-8?q?=20more=20code=20smells?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/managers/database/index.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/managers/database/index.ts b/src/managers/database/index.ts index 44152a7..7ddf0bf 100644 --- a/src/managers/database/index.ts +++ b/src/managers/database/index.ts @@ -4,18 +4,18 @@ import logger from "../../middlewares/logger"; export const connect = async () => { await mongoose .connect(process.env.MONGO_URL) - .then(async (connection) => { + .then((connection) => { logger.info(`💾 Connected to database: ${connection.connection.name}`); }) - .catch(async (e) => { - logger.error("💾 Could not connect to database", e); + .catch(() => { + throw new Error("Error connecting to database."); }); - mongoose.connection.on("error", async (error) => { - logger.error(`💾 ${error}`); + mongoose.connection.on("error", () => { + throw new Error("Failed to connect to database."); }); - mongoose.connection.on("warn", async (warning) => { + mongoose.connection.on("warn", (warning) => { logger.warn(`💾 ${warning}`); }); }; From 993508b0dedd73a46962139096dd4936efc64995 Mon Sep 17 00:00:00 2001 From: Vermium Sifell Date: Sun, 16 Oct 2022 15:00:57 +0200 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=92=A1=20Added=20comment=20for=20data?= =?UTF-8?q?base.connect?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/managers/database/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/managers/database/index.ts b/src/managers/database/index.ts index 7ddf0bf..930f449 100644 --- a/src/managers/database/index.ts +++ b/src/managers/database/index.ts @@ -1,6 +1,7 @@ import mongoose from "mongoose"; import logger from "../../middlewares/logger"; +// Function to connect to MongoDB server export const connect = async () => { await mongoose .connect(process.env.MONGO_URL)