From 229ee5c97b1d6ac0736cdc4d924c0cd5d6de9320 Mon Sep 17 00:00:00 2001 From: Vermium Sifell Date: Fri, 14 Oct 2022 13:54:14 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=91=E2=80=8D=F0=9F=92=BB=20Fixed=20som?= =?UTF-8?q?e=20code=20smells?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../events/messageCreate/modules/counters/index.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/plugins/events/messageCreate/modules/counters/index.ts b/src/plugins/events/messageCreate/modules/counters/index.ts index b5d8d68..35695c0 100644 --- a/src/plugins/events/messageCreate/modules/counters/index.ts +++ b/src/plugins/events/messageCreate/modules/counters/index.ts @@ -1,7 +1,7 @@ import { ChannelType, Message } from "discord.js"; - import logger from "../../../../../middlewares/logger"; import counterSchema from "../../../../../models/counter"; +import logger from "../../../../../middlewares/logger"; export default { execute: async (message: Message) => { @@ -52,16 +52,13 @@ export default { counter.counter += 1; await counter .save() - .then(async () => { + .then(() => { logger.silly( `Counter for guild ${guildId} and channel ${channelId} is now ${counter.counter}` ); }) - .catch(async (err) => { - logger.error( - `Error saving counter for guild ${guildId} and channel ${channelId}`, - err - ); + .catch((err) => { + throw new Error(`Error saving counter to database.`); }); logger.silly(